Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Make sure CJS build always has lowest prio #28829

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Core: Make sure CJS build always has lowest prio #28829

merged 3 commits into from
Aug 8, 2024

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Aug 7, 2024 •
edited by storybook-pr-benchmarking bot
Loading

What I did

Make sure CJS build always has lowest prio

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.3 MB 76.3 MB 0 B -2.02 0%
initSize 167 MB 167 MB 0 B -0.85 0%
diffSize 91.1 MB 91.1 MB 0 B -0.85 0%
buildSize 7.42 MB 7.42 MB 0 B -0.82 0%
buildSbAddonsSize 1.61 MB 1.61 MB 0 B -0.82 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.29 MB 2.29 MB 0 B -0.33 0%
buildSbPreviewSize 351 kB 351 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.45 MB 4.45 MB 0 B -0.79 0%
buildPreviewSize 2.97 MB 2.97 MB 0 B -0.82 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 16.2s 8.4s -7s -829ms -1.56 🔰-93.2%
generateTime 20.6s 27.5s 6.8s 1.52 🔺24.9%
initTime 17.7s 21.8s 4s 0.94 18.5%
buildTime 11.7s 12.4s 710ms -0.98 5.7%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 7.7s 9.6s 1.8s 0.78 19.5%
devManagerResponsive 4.6s 5.3s 704ms 0.07 13.1%
devManagerHeaderVisible 799ms 816ms 17ms -0.29 2.1%
devManagerIndexVisible 836ms 852ms 16ms -0.28 1.9%
devStoryVisibleUncached 1.4s 1.5s 148ms 1.62 🔺9.4%
devStoryVisible 852ms 871ms 19ms -0.3 2.2%
devAutodocsVisible 640ms 728ms 88ms -0.31 12.1%
devMDXVisible 722ms 705ms -17ms -0.33 -2.4%
buildManagerHeaderVisible 745ms 836ms 91ms 0.52 10.9%
buildManagerIndexVisible 748ms 871ms 123ms 0.75 14.1%
buildStoryVisible 787ms 872ms 85ms 0.33 9.7%
buildAutodocsVisible 679ms 753ms 74ms 0.25 9.8%
buildMDXVisible 661ms 726ms 65ms 0.31 9%

@kasperpeulen kasperpeulen added maintenance User-facing maintenance tasks ci:normal labels Aug 7, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 7, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit af4bbe6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kasperpeulen kasperpeulen added the ci:daily Run the CI jobs that normally run in the daily job. label Aug 7, 2024
@kasperpeulen kasperpeulen merged commit ae3b81c into next Aug 8, 2024
104 checks passed
@kasperpeulen kasperpeulen deleted the kasper/export-order branch August 8, 2024 16:25
@github-actions github-actions bot mentioned this pull request Aug 8, 2024
Merged
29 tasks
@yannbf yannbf mentioned this pull request Aug 15, 2024
Closed
This was referenced Oct 3, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 19, 2024
Open
Open
Open
Open
This was referenced Oct 19, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@yannbf yannbf yannbf approved these changes

@valentinpalkovic valentinpalkovic Awaiting requested review from valentinpalkovic

Assignees

@kasperpeulen kasperpeulen

Labels
ci:daily Run the CI jobs that normally run in the daily job. maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kasperpeulen @yannbf @ndelangen